Issue #65 - Fix git hooks install on non-checkout version of repo #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git hook install now checks to make sure that the .git/hooks directory exists before attempting to copy the hook script into location. This ensures no error shows up when installing from a non-cloned version of the code base. Remove the git hook install from non-develop mode installs. If someone is installing the toolkit in 'install' mode instead of 'develop' mode the likelihood of them making changes that the hook would catch seems slim. Update the packaging naming in the git hook
Mejiro-McQueen
referenced
this pull request
in Mejiro-McQueen/Bifrost
Feb 9, 2023
Fix typo in SLE config; update RCF script for new config format (#87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git hook install now checks to make sure that the .git/hooks directory
exists before attempting to copy the hook script into location. This
ensures no error shows up when installing from a non-cloned version of
the code base.
Remove the git hook install from non-develop mode installs. If someone
is installing the toolkit in 'install' mode instead of 'develop' mode
the likelihood of them making changes that the hook would catch seems
slim.
Update the packaging naming in the git hook
Resolve #65