Install errors when using a non-cloned version of the code #65
Assignees
Comments
MJJoyce
added a commit
that referenced
this issue
Jun 6, 2018
Git hook install now checks to make sure that the .git/hooks directory exists before attempting to copy the hook script into location. This ensures no error shows up when installing from a non-cloned version of the code base. Remove the git hook install from non-develop mode installs. If someone is installing the toolkit in 'install' mode instead of 'develop' mode the likelihood of them making changes that the hook would catch seems slim. Update the packaging naming in the git hook
MJJoyce
added a commit
that referenced
this issue
Jun 18, 2018
Git hook install now checks to make sure that the .git/hooks directory exists before attempting to copy the hook script into location. This ensures no error shows up when installing from a non-cloned version of the code base. Remove the git hook install from non-develop mode installs. If someone is installing the toolkit in 'install' mode instead of 'develop' mode the likelihood of them making changes that the hook would catch seems slim. Update the packaging naming in the git hook
MJJoyce
added a commit
that referenced
this issue
Jun 18, 2018
Issue #65 - Fix git hooks install on non-checkout version of repo
MJJoyce
added a commit
that referenced
this issue
Sep 4, 2019
Git hook install now checks to make sure that the .git/hooks directory exists before attempting to copy the hook script into location. This ensures no error shows up when installing from a non-cloned version of the code base. Remove the git hook install from non-develop mode installs. If someone is installing the toolkit in 'install' mode instead of 'develop' mode the likelihood of them making changes that the hook would catch seems slim. Update the packaging naming in the git hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
setup.pyoverwrites the install handlers to add a githook when installing the repo. If the repo isn't cloned (E.g., someone downloaded a zip/tarball of the code) this part of the install causes an error. It doesn't appear to affect the install but it's not terribly user-friendly.The text was updated successfully, but these errors were encountered: