PNI CC Page - fixes and improvements #11242
Conversation
mmmavis
changed the title
mmmavis
force-pushed
the
pni-cc-quiz-fixes
branch
from
fa7e0f1 to
134558b
Compare
mmmavis
changed the title
mmmavis
changed the title
There was a problem hiding this comment.
Hi @mmmavis looking great!
All devices:
Unfortunately, it seems like the email subscription within the quiz is not working (when all the information is filled, the "Sign Up" button becomes active but does not do anything when pressed)
Tablet:
It seems like the icons and copy within the share buttons are a bit misaligned.
Thanks in advance!
Ah right, this is actually something to do on the review app config which I forgot to set it up before sharing the test link. I'll update the config.
Will look into this. |
|
@tessheinricks The misaligning issue on share buttons cannot be easily fixed due to the current styling rules applied to ALL the share buttons on the site. I tried to look for why we forced them to have that Tess, since you are OOO. I'm gonna dismiss your review and ask @danielfmiranda to help with testing on the newsletter signup form. I will merge this PR after I get R+. |
There was a problem hiding this comment.
Hi @mmmavis! Just gave the quiz and newsletter a test and can confirm its working. Also, after taking a look at the code, everything looks great. Approved!
|
🎉 |
* Created a new page type for PNI Privacy Index page (#11107) * Create a new page type for PNI annual consumer creep-o-meter * fix migration conflict * PNI Consumer Creep-O-Meter Page Hero (#11146) * got general section structure in * implemented hero section * PNI CC Page - Sub Nav + 3 middle sections (#11156) * implemented the "sub nav", "big picture trends", "best & worst products" and "by the numbers" sections * PNI CC Page - Quiz section (part 1) (#11211) * Quiz Section Part 1 work. Includes the product selection screen and the result screen only. * PNI CC Page - Outro section + Newsletter box at the bottom of Quiz section (#11219) * Modified the existing PNI newsletter box setup so it can be used for difference scenarios & built Outro section & added newsletter box to Quiz section * fix migration conflicts * linting * updated all face existing SVGs * PNI CC Page - remaining work for Quiz Part 2 (#11224) * Added the newsletter signup prompt and thank you messages to quiz flow * PNI CC Page - Animated Eyes (#11241) * moved hero section to its own fragment file * animated creepy eyes * 11213 quiz share buttons (#11239) * Share buttons on Quiz section * PNI CC Page - MVP version of 'Stay in Control' section (#11245) * Added MVP version of 'Stay in Control' section * PNI CC Page - fixes and improvements (#11242) * fixes and improvements * [PNI CC Page] More fixes (#11248) * optimized face-5.svg * hero creepy face position adjectment --------- Co-authored-by: Daniel Miranda <[email protected]>
https://foundation-s-pni-cc-qui-n071am.herokuapp.com/en/privacynotincluded/articles/annual-consumer-creep-o-meter/
Hi @danielfmiranda , this is a design tweak based PR and Tess has already review everything in the list below. Could you give code changes a quick look as well as double check the signup form in Quiz section works on the review app link? I forgot to fix the basket url in review app config and that was why it wasn't working for Tess when she tested out the form. Thank you!
Quiz section
privacynotincluded.orgon the results screenOther
:(versionface-5.svgwith the pre image optimization version (image optimization stripped off the texture from this particular image)