PNI CC Page - Outro section + Newsletter box at the bottom of Quiz section #11219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…difference scenarios & built Outro section & added newsletter box to Quiz section
mmmavis
commented
Oct 6, 2023
| @@ -132,7 +133,6 @@ let main = { | |||
| if (document.querySelector(`body.pni.catalog`)) { | |||
| HomepageSlider.init(); | |||
| } | |||
| NewsletterBox.toggleVisibilityClasses(); | |||
There was a problem hiding this comment.
this should have not been placed here 😓
mmmavis
changed the title
mmmavis
commented
Oct 6, 2023
| @@ -5,12 +5,14 @@ | |||
| */ | |||
| const NewsletterBox = { | |||
| toggleVisibilityClasses: () => { | |||
| const buyersGuideNewsletterBox = document.querySelector( | |||
There was a problem hiding this comment.
There can be multiple newsletter boxes on the same page. Changing this to use class instead of id
tessheinricks
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Hi @mmmavis incredible work! Everything is looking great.
I'm going to note the opportunity to explore design revisions for the newsletter sign up in the clean up ticket as I don't want to lose the opportunity the champion some of the great insights you brought up. However, that might not be the most optimal spot for that effort (and it will probably require it's own undertaking), so we can re-evaluate that opportunity post launch :).
Thanks again!
...ork-api/networkapi/templates/buyersguide/fragments/consumer_creepometer_page_2023/outro.html
Show resolved
Hide resolved
...ork-api/networkapi/templates/buyersguide/fragments/consumer_creepometer_page_2023/outro.html
Show resolved
Hide resolved
...ork-api/networkapi/templates/buyersguide/fragments/consumer_creepometer_page_2023/outro.html
Outdated
Show resolved
Hide resolved
network-api/networkapi/templates/fragments/buyersguide/pni_newsletter_box.html
Outdated
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/pagemodels/buyersguide/consumer_creepometer_page.py
Outdated
Show resolved
Hide resolved
mmmavis
commented
Oct 6, 2023
network-api/networkapi/wagtailpages/pagemodels/buyersguide/consumer_creepometer_page.py
Outdated
Show resolved
Hide resolved
|
Merging this PR now. Thanks all! |
mtdenton
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Created a new page type for PNI Privacy Index page (#11107) * Create a new page type for PNI annual consumer creep-o-meter * fix migration conflict * PNI Consumer Creep-O-Meter Page Hero (#11146) * got general section structure in * implemented hero section * PNI CC Page - Sub Nav + 3 middle sections (#11156) * implemented the "sub nav", "big picture trends", "best & worst products" and "by the numbers" sections * PNI CC Page - Quiz section (part 1) (#11211) * Quiz Section Part 1 work. Includes the product selection screen and the result screen only. * PNI CC Page - Outro section + Newsletter box at the bottom of Quiz section (#11219) * Modified the existing PNI newsletter box setup so it can be used for difference scenarios & built Outro section & added newsletter box to Quiz section * fix migration conflicts * linting * updated all face existing SVGs * PNI CC Page - remaining work for Quiz Part 2 (#11224) * Added the newsletter signup prompt and thank you messages to quiz flow * PNI CC Page - Animated Eyes (#11241) * moved hero section to its own fragment file * animated creepy eyes * 11213 quiz share buttons (#11239) * Share buttons on Quiz section * PNI CC Page - MVP version of 'Stay in Control' section (#11245) * Added MVP version of 'Stay in Control' section * PNI CC Page - fixes and improvements (#11242) * fixes and improvements * [PNI CC Page] More fixes (#11248) * optimized face-5.svg * hero creepy face position adjectment --------- Co-authored-by: Daniel Miranda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review app: https://foundation-s-new-11194--h460hy.herokuapp.com/en/privacynotincluded/articles/annual-consumer-creep-o-meter/
Note that I'm utilizing the existing newsletter sign up styles in the codebase. For further refinements, let's create a post MVP tickets. Thanks!
Related Tickets
Quiz section
(#11194)
Rhis PR only adds the missing newsletter box to the bottom of the Quiz section. Remaining work related to Quiz will be tackled in following up PRs.
Outro section
(#11136)
PR covers everything for this section