Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable HVAC Modes for NeoStat HC #251

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

ocrease
Copy link
Collaborator

@ocrease ocrease commented Jan 29, 2025

The Options Flow for configuring HVAC modes on thermostats was broken as reported in #249.

This PR fixes that and hopefully addresses the requirements in #78.

  • Requirement 1 was already taken care of, only NeoStat HC devices support anything other than Heat
  • Requirement 2 was supposed to be addressed by the existing Configure functionality but that was broken

With this PR, the Configure (Options) flow only shows NeoStat HCs. Then, depending on the GLOBAL_SYSTEM_TYPE configured on the hub, a list of available modes is shown to the user.

  • If HeatOnly, Heat and Fan Only are options
  • If CoolOnly, Cool and Fan Only are options
  • Otherwise, all options are available - Heat, Cool, Auto, Fan Only

I haven't been able to fully test this since I don't have a NeoStat HC to test with

@ocrease ocrease merged commit 4fbc1b7 into MindrustUK:dev Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant