Feature: Make thermostat's HVAC capabilities (Heat, Cool, Fan, etc.) configurable #78
Comments
|
|
|
These are configurable in e.g. the “simple thermostat” app, but that may not be true for other apps
… On 25 Jun 2021, at 14:12, Roberto Cosenza ***@***.***> wrote:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
yes after updating, i too am having issues with it listing all these other modes.. going to the 3 dots menu, and selecting "heat" in options, doesn't seem to work, it jumps back to fan mode only .. EDIT ......... |
|
I came here to report the same issue with my "heat" mode only thermostats not allowing me to use them properly. They are reporting their details ok, but no target temp is being reported, and the set temp slider isn't available, because they are showing up as heat mode. |
|
@robcos do you have a data capture for your thermostats that support heating and cooling? I want to compare this to stats that do heating only so we can make sure we set the hvac_mode property when loading in the stats. |
|
I'm I’m out of town until the 20th so I can’t help with that right now
…On Wed, 4 Aug 2021 at 18:12, leaskovski ***@***.***> wrote:
@robcos <https://github.com/robcos> do you have a data capture for your
thermostats that support heating and cooling? I want to compare this to
stats that do heating only so we can make sure we set the hvac_mode
property when loading in the stats.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAP3ZSOL2RS32OCMGNTEE3T3FRH3ANCNFSM47J3KZKQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
|
Righty, so I had a look at what was coming out of my stats, and on my Hub (using your neohubapi example code), my stats get listed as... In this you can see the API reports the stats as vents, which isn't right, so I think it might be a bug with their API which we might have to work around. That said, looking at the Hub details... You can see that the global heating mode (GLOBAL_HC_MODE) is set to heating. So I wonder if the individual stats should be overridden by the global stat? It will be interesting to see what yours comes back with for these, as mine is an older version I think. Edit: |
|
I have fired an email to Heatmiser support as I think this is an issue with their API. We can override the VENT value for stats that only have a supported mode of heating, but we shouldn't have to. Lets see what they come back with. |
|
So support came back to me to say that...
So the HC_MODE is not applicable to some stats. Looking at device type (which has to be pulled using the {“GET_ENGINEERS”:0} command, it is my guess that only the HC device types should use HC_MODE, where as the others should just ignore it... I think only device types 8 and 11 need to use HC MODE. Edit.... Im still of the opinion though that stats supported hvac_modes should be set in relation to what is in the AVAILABLE_MODES property of the stat data. |
|
was trying to see how mine compared and get it fixed better !... |
|
@gadget78 , I was using the repo for the neohubapi which this component now uses (https://gitlab.com/neohubapi/neohubapi). When you run the example.py code, it dumps all the data out to the command line window, so you can grab it from there. |
|
This I believe addresses the issue of only setting the hvac mode if the device lists that mode as part of its available modes. Works for my Neo Air thermostats allowing successful control via the thermostat card, which now only shows the 'heat' and 'Off'/'Standby' modes |
|
Thanks @lynchdonala, LGTM. That's an improvement. We should still make the modes configurable though as some modes may be available in the thermostat but not in the actual home (e.g. fan mode) |
|
@lynchdonala I tested your patch on the neoStat V2 (only available mode is heading) and it works great |
|
@lynchdonala one caveat though. your code relies on the assumption that the possible values AVAILABLE_MODES are the same than the one used by homeassistant climate integration |
|
@jfparis and @lynchdonala it looks similar to the changes I made in my branch of the code... https://github.com/leaskovski/Heatmiser-for-home-assistant/commit/7d829f53e4273cc4b0c1e1d668ce3441d03c21e5 |
|
@leaskovski |
|
@jfparis I can't remember why I did it like that, but it was probably to do it with the least amount of code changes! lol. Yes, in theory I can't see why these settings would change normally, so only when the thermostat is initialised, would it really need to be set. |
|
@jfparis @leaskovski I've tested the changes proposed by @leaskovski, and I've found that they don't work (for me). I got it to work with some minor changes. Below are the changes I made:
|
|
@ribbal What type of thermostat do you have? Fan / HVAC capable or just heating? Mine is just heating so it would be good if a FAN /HVAC person could test it Looks like we have a solution to the bug and all we need is a PR |
|
I only have heating stats (plus a timer for the hot water)
…On Fri, 29 Oct 2021 at 14:29, Jean-François Paris ***@***.***> wrote:
@ribbal <https://github.com/ribbal>
I am not fully surprised re 2 and 3. I was actually googling in the
background because | is not an operator that I used very often but I
wanted to test in the evening before commenting
What type of thermostat do you have? Fan / HVAC capable or just heating?
Mine is just heating so it would be good if a FAN /HVAC person could test it
Looks like we have a solution to the bug and all we need is a PR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHKF5QVQZODVZ2JJCIMJPETUJKVUBANCNFSM47J3KZKQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
I've created a PR (#85), which will hopefully make things better. Thanks to @leaskovski for doing the initial work and prompting me to have a look. |
|
Thanks @ribbal |
|
I guess this can be closed now |
|
I don't think this solves the issue I pointed out. In other words, I think we have fixed (1) from my original issue but (2) is still pending |
|
Hi @robcos, this is what I am seeing for my neoStats: Please could you post an image of what you see using latest version of this Heatmiser integration (is it still the same as your original screenshot dated 25th June 2021 - I did experience the same last year, but not any longer)? Could it be that the settings of your stats are set to support multiple modes (heat, fan, cool, etc) and this is simply being reflected in homeassistant? |
|
@robcos, please could you post your debug logs here? |
|
Yes, @ribbal it is because the thermostat supports "VENT" (and afaik it can't be changed) but I have no vent facility in my home. I think what you are experiencing is different - let me explain it better, once more. Your change is reading the different modes that the thermostat supports - that's great. Without your change, we would simply hardcode all modes - no matter what hardware thermostat you have. Nevertheless, there are thermostats that support a lot of modes (e.g. Neostat HC) but that does not mean that the user has the actual facilities supported by the thermostat. Specifically, you may have a VENT thermostat but no fans in the house so, ideally, home assistant should be configured not to show the VENT icon. I'm not saying that home assistant should automatically detect this (it's impossible) but rather we should give the user the opportunity to hide the mode. Note that clicking the "vent" button actually puts the thermostat in a non-working state so it is quite bad from a user point of view |
|
@robcos, ahh I see; I don't have any Neostat HCs. Looking at the manual (see: https://www.heatmiser.com/en/digital-thermostats-manual-finder/), is it possible for you to disable the Fan/VENT from the Feature Menu (Feature 10 'System Type')? |
|
Good hint! Unfortunately it does not do what we were hoping for (would have been great to be able to disable the vent in the hardward thermostat). I did some debugging and this is the result:
As you can see, the thermostat almost always returns ['heat', 'vent'] which is incorrect. One full instance of the logs:
|
|
Added the ability to manually configure (override default) HVAC modes, in this PR #103
Restart HA, after changing any of the settings. |
|
Looks like this is feature complete. Leaving for a week for further comments before closing. |
|
I never had a way of properly testing this earlier and I am afraid it is pretty broken. I'm unable to even see the 2 temperatures once I use this version |
|
Have started re-building this feature in dev. Keep an eye out for sometime in the future. This hasn't been forgotten. |
|
Have managed to score a neoStat-HC on eBay that I'll be adding to my test bed to further flesh out this feature. |
|
Need to expand const.py list to a dictionary which will include capabilities against correct products, then include custom configuration to enable / disable / select the desired feature subset as viable via persistent configuration within Home Assistant's registry. |
MindrustUK
changed the title
|
This also falls into tech debt for features like |
|
@robcos are you still monitoring this issue and do you still have your NeoStat HCs? If you do, would you be willing to try the latest pre-relase version and see how you get on? |
|
@MindrustUK I don't plan to work on this, but based on everything I've discovered in the past month, this is only relevant for NeoStat HCs and even then the only configuration required here is whether Fan Only / Vent is enabled. Enabling heating and/or cooling can be done elsewhere, but Vent mode is always an option on NeoStat HCs. This feature is only to support users who have a NeoStat HC but it has not fan to control. |
|
It's certainly one of the more complex use cases. I'll revisit this when I have time, I secured one of the the NeoStat HC devices a while back and having come this far it seems a shame not to complete the support. |
|
v3.1.0-beta.4 has been released which updates the Configure flow. It is only relevant for installations with NeoStat HC devices. For all other devices, only Heat (and Off) is supported so there is no configuration to do. For NeoStat HC devices, the list of options depends on the
You can untick some options if they are not relevant on your installation. I haven't got a NeoStat HC for real world testing. If any of you want to try it and feedback, that would be great. Please include the diagnostics output (from "Download Diagnostics") if you have any issues. |
|
Hi @ocrease I've given this a quick smoke test, everything looks good here for me. Tried the device control and configuring the options around it. All looking good here. |
|
Further improvements in v3.1.0-beta.6. See #254 for details. I think it is feature complete now, but I haven't got a NeoStat HC to test with. |
|
@ocrease quick smoke test shows everything working as I'd expect, as my NeostatHC is on a desk and not in "production" use, I'd have to wait for other users in the thread to confirm correct behavior. |
#75 adds support for new hvac modes. These modes are hardcoded however there are 2 minor problems with this:
In both cases, we should not show modes/ui for modes that are not meaningful to the user.
The easiest is to provide some configuration, per thermostat. Bonus would be to infer the default configuration for point 1 at least.
The text was updated successfully, but these errors were encountered: