Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Paste file path as file uri link" the "title" of the link is now only the file title, not the full path. #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aidan-gibson
Copy link

"Paste file path as file uri link" the "title" of the link is now only the file title, not the full path.

Instead of this
image

We have this
image

Thank you for this plugin btw, it's been a real lifesaver for me!

@MichalBures
Copy link
Owner

Thanks for this! I've added this functionality in the new 1.4.0 release. Let me know if you encounter any issues with it.

@aidan-gibson
Copy link
Author

Thanks for incorporating this into 1.4.0, however, your code doesn't work when there's a space.
It'll give [CSCI121%20Assignments](file:///Users/aidangibson/PycharmProjects/CSCI121%20Assignments)

When it should give [CSCI121 Assignments](file:///Users/aidangibson/PycharmProjects/CSCI121%20Assignments)

@aidan-gibson aidan-gibson reopened this Aug 21, 2022
@MichalBures
Copy link
Owner

Fixed in 1.4.1, thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants