Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Permit Signature #217

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Introducing Permit Signature #217

merged 2 commits into from
Mar 1, 2023

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Mar 1, 2023

What: in this PR we are introducing a specific Typed Data V4 signature: Permit. According to the specs for EIP-2612, the signature will have a data type Permit with the following data fields:

  "message": {
    "owner": owner,
    "spender": spender,
    "value": value,
    "nonce": nonce,
    "deadline": deadline
  }
permit.mp4

How:

  • the first part of the work, and the scope of this PR, consists in introducing a Permit signature.
  • a future PR will take care of importing an ERC20 Permit contract which implements the permit signature, and complete the flow by adding the functionality of executing the Permit and seeing how allowance is increased only by signing a Permit signature.
  • the signature split of v, r and s fields in this PR is a preparatory work, that would be needed for the future PR

@seaona seaona merged commit 93bcf4c into main Mar 1, 2023
@seaona seaona deleted the permit branch March 1, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test-dapp] Introduce Permit Signature on the Test-Dapp
2 participants