Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-dapp] Introduce Permit Signature on the Test-Dapp #17941

Closed
seaona opened this issue Mar 1, 2023 · 0 comments · Fixed by MetaMask/test-dapp#217
Closed

[test-dapp] Introduce Permit Signature on the Test-Dapp #17941

seaona opened this issue Mar 1, 2023 · 0 comments · Fixed by MetaMask/test-dapp#217
Assignees
Labels
team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead

Comments

@seaona
Copy link
Contributor

seaona commented Mar 1, 2023

What: introducing a specific Typed Data V4 signature: Permit. According to the specs for EIP-2612, the signature will have a data type Permit with the following data fields:

  "message": {
    "owner": owner,
    "spender": spender,
    "value": value,
    "nonce": nonce,
    "deadline": deadline
  }

How:

  • the first part of the work, and the scope of this ticket, consists in introducing a Permit signature.
  • a future PR will take care of importing an ERC20 Permit contract which implements the permit signature, and complete the flow by adding the functionality of executing the Permit and seeing how allowance is increased only by signing a Permit signature.
@seaona seaona added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Mar 1, 2023
@seaona seaona self-assigned this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@seaona and others