Use verifyPassword instead of submitPassword when exporting priv key #9288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9287 which was when submitPassword is called will fully clear the keyring state https://github.com/MetaMask/KeyringController/blob/master/index.js#L155 https://github.com/MetaMask/KeyringController/blob/ad823d0ac15560d2bd22f737516736361f3ea107/index.js#L562 https://github.com/MetaMask/KeyringController/blob/ad823d0ac15560d2bd22f737516736361f3ea107/index.js#L726 Also, pass hideWarning action prop so it will clear the appState.warning if a correct password is never provided on componentWillUnmount
tmashuang
changed the title
Builds ready [5a0a9c3]
Page Load Metrics (443 ± 66 ms)
|
Gudahtt
reviewed
Aug 26, 2020
Co-authored-by: Mark Stacey <[email protected]>
Co-authored-by: Mark Stacey <[email protected]>
Builds ready [d622acd]
Page Load Metrics (450 ± 70 ms)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9287
Fixes #9230
Which was when submitPassword is called will fully clear the keyring state
https://github.com/MetaMask/KeyringController/blob/master/index.js#L155
Also, pass hideWarning action prop so it will clear the appState.warning if a correct password is never provided on componentWillUnmount