Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounts not listed when a wrong password is entered for private key #9287

Closed
srirambv opened this issue Aug 21, 2020 · 0 comments · Fixed by #9288
Closed

Accounts not listed when a wrong password is entered for private key #9287

srirambv opened this issue Aug 21, 2020 · 0 comments · Fixed by #9288
Labels
Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. type-bug

Comments

@srirambv
Copy link

Describe the bug
Accounts not listed when a wrong password is entered for Export Private Key

To Reproduce (REQUIRED)
Steps to reproduce the behavior, libraries used with version number, and/or any setup information to easily reproduce:

  • Clean install MM extension
  • Go to Menu and click on Account details
  • Click on Export Private Key
  • Enter incorrect password, shows incorrect password message
  • Close and click on profile menu, no accounts listed
  • Click account menu, throws error page
  • Reload page brings back account details
  • Click account menu, throws error page
  • Lock account and log back in
  • Click on account menu, no error page is shown

Expected behavior
Should show created accounts

Screenshots
https://youtu.be/iYdvkf7GyTo

Browser details (please complete the following information):

  • OS: OSX/Windows/Linux
  • Hardware Wallet: Not verified
  • Browser: Brave Browser
  • MetaMask Version: 8.0.8

Additional context (Error Messages, etc.)
Related issues:
#8626
brave/brave-browser#10957
@srirambv srirambv mentioned this issue Aug 21, 2020
Closed
@srirambv srirambv changed the title No accounts listed when wrong password is entered for Export private key Accounts not listed when a wrong password is entered for private key Aug 21, 2020
tmashuang added a commit that referenced this issue Aug 21, 2020
@tmashuang
Use verifyPassword instead of submitPassword when exporting priv key
ee8302b 
Fixes #9287 which was when submitPassword is called will fully clear the keyring state

https://github.com/MetaMask/KeyringController/blob/master/index.js#L155
https://github.com/MetaMask/KeyringController/blob/ad823d0ac15560d2bd22f737516736361f3ea107/index.js#L562
https://github.com/MetaMask/KeyringController/blob/ad823d0ac15560d2bd22f737516736361f3ea107/index.js#L726

Also, pass hideWarning action prop so it will clear the appState.warning if a correct password is never provided on componentWillUnmount
@tmashuang tmashuang mentioned this issue Aug 21, 2020
Merged
@tmashuang tmashuang added type-bug Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels Aug 21, 2020
ryanml added a commit to ryanml/metamask-extension that referenced this issue Aug 25, 2020
@ryanml
Fixes MetaMask#9287 - Verifies password when exporting private key
a8d5162
@ryanml ryanml mentioned this issue Aug 25, 2020
Closed
tmashuang added a commit that referenced this issue Aug 26, 2020
@tmashuang @Gudahtt
Use verifyPassword instead of submitPassword when exporting priv key (#…
79d4770 
…9288)

* Use verifyPassword instead of submitPassword when exporting priv key

Fixes #9287 which was when submitPassword is called will fully clear the keyring state

https://github.com/MetaMask/KeyringController/blob/master/index.js#L155
https://github.com/MetaMask/KeyringController/blob/ad823d0ac15560d2bd22f737516736361f3ea107/index.js#L562
https://github.com/MetaMask/KeyringController/blob/ad823d0ac15560d2bd22f737516736361f3ea107/index.js#L726

Also, pass hideWarning action prop so it will clear the appState.warning if a correct password is never provided on componentWillUnmount

* Hide Warning on componentWillUnmount

* Update exportAccount tests to verifyPassword

* Update ui/app/store/actions.js
Co-authored-by: Mark Stacey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. type-bug
Projects
None yet
Milestone
No milestone
2 participants
@tmashuang @srirambv