Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source map validator target files #9133

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 4, 2020

All JavaScript files included in the final bundle are now listed as target files. The phishing-detect.js file is the only new file to be validated that was not validated before.

Any files that are expected to fail validation are commented out, with a note explaining why they're expected to fail.

@Gudahtt Gudahtt marked this pull request as ready for review August 4, 2020 14:53
@Gudahtt Gudahtt requested review from kumavis and a team as code owners August 4, 2020 14:53
rekmarks
rekmarks previously approved these changes Aug 4, 2020
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [5f22ba2]
Page Load Metrics (579 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint2910241178
domContentLoaded3346625788139
load3366645798139
domInteractive3346625778139

@Gudahtt Gudahtt force-pushed the update-source-map-validator-target-files branch from 5f22ba2 to bbcdc15 Compare August 4, 2020 15:10
All JavaScript files included in the final bundle are now listed as
target files. The `phishing-detect.js` file is the only new file to be
validated that was not validated before.

Any files that are expected to fail validation are commented out, with
a note explaining why they're expected to fail.
@Gudahtt Gudahtt force-pushed the update-source-map-validator-target-files branch from bbcdc15 to e0bbf6c Compare August 4, 2020 15:14
@metamaskbot
Copy link
Collaborator

Builds ready [e0bbf6c]
Page Load Metrics (565 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint289738178
domContentLoaded3156725648641
load3176735658641
domInteractive3156715648641

@Gudahtt Gudahtt merged commit e1b9cfa into develop Aug 4, 2020
@Gudahtt Gudahtt deleted the update-source-map-validator-target-files branch August 4, 2020 16:45
Gudahtt added a commit that referenced this pull request Aug 5, 2020
* origin/develop:
  Fix connection removal bug (#9137)
  Add source map validator to CI (#9135)
  Update source map validator target files (#9133)
  Improve sourcemap validator console report (#9131)
  Add `validate-source-maps` npm script (#9134)
  Non-zero exit code upon failure to validate source maps (#9132)
  remove unused tx-list styles (#9121)
  delete unused confirm styles (#9118)
Gudahtt added a commit that referenced this pull request Aug 7, 2020
All JavaScript files included in the final bundle are now listed as
target files. The `phishing-detect.js` file is the only new file to be
validated that was not validated before.

Any files that are expected to fail validation are commented out, with
a note explaining why they're expected to fail.
Gudahtt added a commit that referenced this pull request Aug 10, 2020
* origin/master: (44 commits)
  Add category in eventOpts (#9164)
  Update changelog for v8.0.7 (#9161)
  Version v8.0.7
  Remove web3 e2e tests (#9159)
  Add web3 usage metrics, prepare for web3 removal (#9144)
  Use `pathname` instead of URL for `currentPath` metrics parameter (#9158)
  Remove `url` parameter from `metricsEvent` (#9157)
  Change MetaMetrics category for background events (#9155)
  remove .network-name height
  Use [email protected] (#9154)
  Update 'react-devtools' to ^4.8.0 (#9140)
  Fix connection removal bug (#9137)
  Add source map validator to CI (#9135)
  Update source map validator target files (#9133)
  Improve sourcemap validator console report (#9131)
  Add `validate-source-maps` npm script (#9134)
  Non-zero exit code upon failure to validate source maps (#9132)
  Update `brfs` from v1.6.1 to v2.0.2 (#9115)
  Factor out `getEnvironment` function in build script (#9114)
  Update `browserify` from v16.2.3 to v16.5.1 (#9113)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants