Skip to content

Commit

Permalink
Update source map validator target files (#9133)
Browse files Browse the repository at this point in the history
All JavaScript files included in the final bundle are now listed as
target files. The `phishing-detect.js` file is the only new file to be
validated that was not validated before.

Any files that are expected to fail validation are commented out, with
a note explaining why they're expected to fail.
  • Loading branch information
Gudahtt committed Aug 7, 2020
1 parent e17c18f commit b490da3
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion development/sourcemap-validator.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,15 @@ start().catch((error) => {


async function start () {
const targetFiles = [`inpage.js`, `contentscript.js`, `ui.js`, `background.js`]
const targetFiles = [
`background.js`,
// `bg-libs`, skipped because source maps are invalid due to browserify bug: https://github.com/browserify/browserify/issues/1971
// `contentscript.js`, skipped because the validator is erroneously sampling the inlined `inpage.js` script
`inpage.js`,
'phishing-detect.js',
`ui.js`,
// `ui-libs.js`, skipped because source maps are invalid due to browserify bug: https://github.com/browserify/browserify/issues/1971
]
let valid = true

for (const buildName of targetFiles) {
Expand Down

0 comments on commit b490da3

Please sign in to comment.