Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popup/notification when browser is in fullscreen, primarily on macOS. #9075

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Fix popup/notification when browser is in fullscreen, primarily on macOS. #9075

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68bd4a5
Fix popup/notification when browser is in fullscreen, primarily on OSX.
tmashuang Jul 24, 2020
44d6e5d
Feedback commit
tmashuang Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/scripts/lib/notification-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ export default class NotificationManager {
})

// Firefox currently ignores left/top for create, but it works for update
if (popupWindow.left !== left) {
if (popupWindow.left !== left && popupWindow.state !== 'fullscreen') {
// if (popupWindow.left !== left) {
tmashuang marked this conversation as resolved.
Show resolved Hide resolved
await this.platform.updateWindowPosition(popupWindow.id, left, top)
}
this._popupId = popupWindow.id
Expand Down