Fix popup/notification when browser is in fullscreen, primarily on macOS.

[tmashuang]

The issue was reported internally via Slack. User was running macOS Chrome in fullscreen mode where Chrome is created in a new Desktop workspace.

The issue reproduced on macOS Chrome in fullscreen/maximized view overrides the explicitly set width and height for windows.create(). Possibly not overrides, but creates a window based off of the window that it was created from. Related Chrome bugs ^{1 2}

The fullscreen popup.left pixel will calculate the window position incorrectly since we set and assume the width of the created window. The incorrect left position the window and transition the focus Desktop/Workspace incorrectly and make it seem to lose focus of the new window/workspace. Incidentally this will make the popup full width/height, and create a new workspace for the view, which we have no control over until Chrome fixes it.

This will check if the popup is 'fullscreen', which it gets passed from the origin window, if so then don't reposition the window. If Chrome fixes the issue we can revert this change.

Screenshots are of the inconsistent scoped window attributes on Chrome and Firefox. Both are in Fullscreen/Desktop/Workspace and initiating a Connect Request, or any action that triggers popup/notification ui.

Chrome lastFocused

Firefox lastFocused

Chrome created popupWindow

Firefox created popupWindow

1. Bug 1

2. Bug 2

[metamaskbot]

Builds ready [68bd4a5]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (657 ± 34 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	31	119	46	21	10
		domContentLoaded	407	762	655	71	34
		load	413	764	657	71	34
		domInteractive	407	762	655	71	34

[Gudahtt]

Good catch! This additional window position update is definitely not desired on fullscreen.

I'm not entirely sure how those two linked Chrome bugs are related? The first seems to relate to max/min window sizes specifically (which is a feature of the Chrome App API, not the Extension API), and the second seems to be about a maximum popup size (which we aren't trying to exceed here). But nonetheless, this change is good.

[Gudahtt]

LGTM!

[metamaskbot]

Builds ready [44d6e5d]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (649 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	31	101	56	25	12
		domContentLoaded	397	844	647	105	51
		load	399	846	649	106	51
		domInteractive	397	844	647	105	51