Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents keyrings from being cleared when verifying password for seed phrase #9063

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Prevents keyrings from being cleared when verifying password for seed phrase #9063

merged 1 commit into from
Jul 24, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jul 23, 2020 •
edited
Loading

@ryanml ryanml requested a review from a team as a code owner July 23, 2020 07:10
ryanml
ryanml commented Jul 23, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Gudahtt
Copy link
Member

Gudahtt commented Jul 23, 2020

It was suggested to create another keyring method similar to submitPassword, but we still need to unlock the actual vault and populate keyrings to get the seedphrase, so it was a lot of duplication.

I'm confused; why would we need to unlock the vault and populate the keyrings in this situation? The reveal seed phrase screen is only accessibly when the vault is unlocked, so... we shouldn't need to unlock it again.

@ryanml ryanml requested a review from Gudahtt July 24, 2020 22:12
Gudahtt
Gudahtt approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit b4663eb into MetaMask:develop Jul 24, 2020
@ryanml ryanml mentioned this pull request Jul 27, 2020
Merged
Gudahtt pushed a commit that referenced this pull request Aug 7, 2020
@ryanml @Gudahtt
Fixes #8626 - verifies password on requesting seed phrase (#9063)
230d431
@Gudahtt Gudahtt mentioned this pull request Aug 7, 2020
Merged
@metamaskbot metamaskbot mentioned this pull request Aug 7, 2020
Merged
@Gudahtt Gudahtt mentioned this pull request Aug 18, 2020
Closed
@ryanml ryanml mentioned this pull request Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI broken after submitting incorrect password on reveal seed phrase screen
2 participants
@ryanml @Gudahtt