Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Adds method to verify password #71

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Adds method to verify password #71

merged 1 commit into from
Jul 23, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jul 23, 2020

@ryanml ryanml mentioned this pull request Jul 23, 2020
Merged
Gudahtt
Gudahtt suggested changes Jul 23, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting clearKeyrings will result in every keyring being duplicated. I'm not sure this is a viable approach.

@ryanml
Copy link
Contributor Author

ryanml commented Jul 23, 2020

Mistake on my part, as discussed in DM will update

@ryanml ryanml changed the title Adding optional param to preserve keyrings when submitting password Adds method to verify password Jul 23, 2020
@ryanml ryanml requested a review from Gudahtt July 23, 2020 19:00
Gudahtt
Gudahtt approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Gudahtt Gudahtt merged commit 5f630e2 into MetaMask:master Jul 23, 2020
Gudahtt added a commit that referenced this pull request Jul 23, 2020
@Gudahtt
v6.1.0
e7ca290 
This release includes a new `verifyPassword` method (#71).
@Gudahtt Gudahtt mentioned this pull request Jul 23, 2020
Merged
Gudahtt added a commit that referenced this pull request Jul 24, 2020
@Gudahtt
v6.1.0 (#72)
621cdbf 
This release includes a new `verifyPassword` method (#71).
ryanml added a commit to brave/KeyringController that referenced this pull request Jul 24, 2020
@ryanml
Adds method to verify password (MetaMask#71)
a76592e
ryanml added a commit to brave/KeyringController that referenced this pull request Jul 24, 2020
@ryanml
Adds method to verify password (MetaMask#71)
ac5af2a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanml @Gudahtt