Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve on 0x #9048

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Resolve on 0x #9048

merged 1 commit into from
Jul 22, 2020

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Jul 22, 2020

Need to see which types of contract interactions and result in 0x fourBytePrefix and how we can mitigate the getContractMethodData() to those contracts, and/or the way we slice the tx data need adjusting

const fourBytePrefix = prefixedData.slice(0, 10)
, and/or we are setting that default tx data to 0x somewhere.

This to prevent calls to fourbyte on knownMethod['0x']

@tmashuang tmashuang requested a review from a team as a code owner July 22, 2020 10:10
@metamaskbot
Copy link
Collaborator

Builds ready [e3efb19]
Page Load Metrics (624 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29100542613
domContentLoaded3377456237536
load3397476247536
domInteractive3377456237536

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I was going to suggest we add a similar guard in the one other place that getMethodDataAsync is used, but it turns out that component was unused (#9050)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants