Skip to content

Commit

Permalink
Hide loading indication after personal_sign (#9006)
Browse files Browse the repository at this point in the history
The loading indication had remained after successfully signing with
`personal_sign`. This mistake was introduced accidentally in #8434.

This is noticeable if you confirm the signature in the popup UI or
fullscreen UI, as they remain open after signing. The notification UI
closes after signing without waiting for this loading indicator to be
removed.
  • Loading branch information
Gudahtt authored Jul 16, 2020
1 parent acaa648 commit 7333d82
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ui/app/store/actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,7 @@ export function signPersonalMsg (msgData) {
dispatch(displayWarning(error.message))
throw error
}
dispatch(hideLoadingIndication())
dispatch(updateMetamaskState(newState))
dispatch(completedTx(msgData.metamaskId))
dispatch(closeCurrentNotificationWindow())
Expand Down

0 comments on commit 7333d82

Please sign in to comment.