Fix account name editing #8801
Merged
Fix account name editing #8801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editing the name of an account was accidentally made impossible when FontAwesome was updated in #8256, because the icon we used to use for the edit button (`fa fa-pencil`) was no longer free. The icon has been switched to `fas fa-pencil-alt`, which is free.
Builds ready [65a89d6]
Page Load Metrics (750 ± 14 ms)
|
Screenshots:Before:
After:
|
brad-decker
approved these changes
Jun 12, 2020
Gudahtt
added a commit
that referenced
this pull request
Jun 16, 2020
* origin/develop: (58 commits) Fix site icon fallback letter (#8815) add hover style to list-item (#8813) Fix site icon size (#8814) Consolidate connected account alerts (#8802) lowercase web3 Use [email protected] (#8809) Update app/_locales/en/messages.json Update app/_locales/en/messages.json also remove 'dapp' from descriptions remove all user-facing instances of 'dapp' update button styling on home/asset page (#8800) Fix handling of permissions of removed accounts (#8803) Clear permssions during createNewVaultAndRestore (#8804) Hide token transfers on ETH asset page (#8799) Fix account name editing (#8801) Fix connect flow account list height (#8798) Update color of menu item icons (#8797) Update "Connected accounts" empty description (#8796) Stop reporting failed transactions to Sentry (#8795) Omit state snapshot from Sentry errors (#8794) ...
|
I started to test the sent beta link:
|
|
Hi @xmaysonnave, that test build doesn’t have the changes introduced by this (and other) PRs. So, the problem is in fact fixed! Thank you for being a user tester 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editing the name of an account was accidentally made impossible when FontAwesome was updated in #8256, because the icon we used to use for the edit button (
fa fa-pencil) was no longer free. The icon has been switched tofas fa-pencil-alt, which is free.