Use @fortawesome/fontawesome-free npm package
#8256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
use-font-awesome-free-package
branch
from
d116c49 to
b55bc5c
Compare
The official npm package for Font Awesome Free is now used instead of the vendored styles. Previously we had been using v4.4.0, now we're using v5.13.0. We're now importing the Font Awesome SCSS modules instead of using the minified CSS bundle. This integrates more cleanly into our build system, and it lets us use their mixins directly in the future if we need to. The variable `fa-font-path` has been set to reference our font directory, as instructed here: https://fontawesome.com/how-to-use/on-the-web/using-with/sass#compile
Gudahtt
force-pushed
the
use-font-awesome-free-package
branch
from
b55bc5c to
db7f4ba
Compare
Gudahtt
changed the base branch from
use-main-styles-for-phishing-page
to
develop
Gudahtt
added a commit
that referenced
this pull request
Jun 12, 2020
Editing the name of an account was accidentally made impossible when FontAwesome was updated in #8256, because the icon we used to use for the edit button (`fa fa-pencil`) was no longer free. The icon has been switched to `fas fa-pencil-alt`, which is free.
Gudahtt
added a commit
that referenced
this pull request
Jun 13, 2020
Editing the name of an account was accidentally made impossible when FontAwesome was updated in #8256, because the icon we used to use for the edit button (`fa fa-pencil`) was no longer free. The icon has been switched to `fas fa-pencil-alt`, which is free.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official npm package for Font Awesome Free is now used instead of the vendored styles. Previously we had been using v4.4.0, now we're using v5.13.0.
We're now importing the Font Awesome SCSS modules instead of using the minified CSS bundle. This integrates more cleanly into our build system, and it lets us use their mixins directly in the future if we need to.
The variable
fa-font-pathhas been set to reference our font directory, as instructed here:https://fontawesome.com/how-to-use/on-the-web/using-with/sass#compile