Refactor TokenBalance component
#8752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TokenBalance` component now uses the new `useTokenTracker` hook instead of the `withTokenTracker` higher-order component. The component was converted from a split container/component to a functional component so that the hook could be used. The prop `withSymbol` was removed from a few call sites, as it was no longer used. An empty string was substituted for any falsy `string` or `symbol` because that's what the `withTokenTracker` higher-order component did.
Builds ready [c4b48df]
Page Load Metrics (706 ± 97 ms)
|
brad-decker
approved these changes
Jun 5, 2020
Gudahtt
added a commit
that referenced
this pull request
Jun 10, 2020
* origin/develop: (35 commits) Delete unused InfuraController & tests (#8773) Permissions: Do not display HTTP/HTTPS URL schemes for unique hosts (#8768) Refactor confirm approve page (#8757) blocklisted -> blocked Update app/scripts/contentscript.js blacklist -> blocklist; whitelist -> safelist replace blacklist with blocklist Delete unused transaction history test state (#8769) fix-formatting-of-gif (#8767) Order accounts on connect page (#8762) add gif for loading dev build (#8766) Bump websocket-extensions from 0.1.3 to 0.1.4 (#8759) Fix prop type mismatch (#8754) use grid template to position list item (#8753) Fix account menu entry for imported accounts (#8747) Fix permissions connect close and redirect behavior (#8751) Refactor `TokenBalance` component (#8752) Fix 'Remove account' in Account Options menu (#8748) move activation logic into token rates controller (#8744) asset outdated warning inline on full screen (#8734) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TokenBalancecomponent now uses the newuseTokenTrackerhook instead of thewithTokenTrackerhigher-order component. The component was converted from a split container/component to a functional component so that the hook could be used.The prop
withSymbolwas removed from a few call sites, as it was no longer used. An empty string was substituted for any falsystringorsymbolbecause that's what thewithTokenTrackerhigher-order component did.