asset outdated warning inline on full screen #8734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
changed the title
brad-decker
force-pushed
the
fullscreen-asset-page-ui
branch
from
633ef84 to
32d9dd5
Compare
Builds ready [32d9dd5]
Page Load Metrics (607 ± 53 ms)
|
brad-decker
force-pushed
the
fullscreen-asset-page-ui
branch
3 times, most recently
from
510a3ee to
8ff4e00
Compare
Builds ready [8ff4e00]
Page Load Metrics (698 ± 61 ms)
|
Gudahtt
reviewed
Jun 5, 2020
brad-decker
force-pushed
the
fullscreen-asset-page-ui
branch
from
8ff4e00 to
da62b2d
Compare
The asset list item and transaction list item do not make great use of screen realestate when in fullscreen mode on larger displays/windows. This PR adds in a new prop for list-item for displaying content in the middle of the list-item when on these types of screens. To facilitate this, some updates were made to styling to allow for the list item to better control how items are laid out in various breakpoints. This works makes it possible to display the outdated balance warning inline in the middle section of the list item, and convert to a tooltip when on small displays.
brad-decker
force-pushed
the
fullscreen-asset-page-ui
branch
from
da62b2d to
9dadf78
Compare
Builds ready [9dadf78]
Page Load Metrics (654 ± 53 ms)
|
Gudahtt
added a commit
that referenced
this pull request
Jun 10, 2020
* origin/develop: (35 commits) Delete unused InfuraController & tests (#8773) Permissions: Do not display HTTP/HTTPS URL schemes for unique hosts (#8768) Refactor confirm approve page (#8757) blocklisted -> blocked Update app/scripts/contentscript.js blacklist -> blocklist; whitelist -> safelist replace blacklist with blocklist Delete unused transaction history test state (#8769) fix-formatting-of-gif (#8767) Order accounts on connect page (#8762) add gif for loading dev build (#8766) Bump websocket-extensions from 0.1.3 to 0.1.4 (#8759) Fix prop type mismatch (#8754) use grid template to position list item (#8753) Fix account menu entry for imported accounts (#8747) Fix permissions connect close and redirect behavior (#8751) Refactor `TokenBalance` component (#8752) Fix 'Remove account' in Account Options menu (#8748) move activation logic into token rates controller (#8744) asset outdated warning inline on full screen (#8734) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards implementing the full-screen design for the asset page
This PR:
midContentwhich I can imagine might be used in other use cases as well.midContentpresent.warningprop on asset-list-item to be multipurpose so that it can be used to build the tooltip and inline experience.Does not include:
Screenshots will be added once CI passes
Asset page Responsive Gif
Transaction list item screenshot before
Transaction list item screenshot after