Make seed phrase import case insensitive #8246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktoda
requested review from
Gudahtt,
jennypollack and
whymarrh
as code owners
marktoda
force-pushed
the
makeSeedPhraseCaseInsensitive
branch
2 times, most recently
from
e1d3860 to
26e66c1
Compare
The user-specified seed phrase during the first-time-flow import step required the phrase to be entered in all lowercase. The case does not add any extra entropy to the seed, so there's no reason to be case sensitive. Flexibility here will improve the onboarding UX. This commit makes the entered seed phrase case insensitive. Fixes MetaMask#8171
marktoda
force-pushed
the
makeSeedPhraseCaseInsensitive
branch
from
26e66c1 to
c9d716d
Compare
whymarrh
reviewed
Mar 29, 2020
...first-time-flow/create-password/import-with-seed-phrase/import-with-seed-phrase.component.js
Show resolved
Hide resolved
|
Thanks @whymarrh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user-specified seed phrase during the first-time-flow import step
required the phrase to be entered in all lowercase. The case does not
add any extra entropy to the seed, so there's no reason to be case
sensitive. Flexibility here will improve the onboarding UX.
This commit makes the entered seed phrase case insensitive.
Fixes #8171