Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seed phrase should be forced to lowercase before test/importing #8171

Closed
mryellow opened this issue Mar 8, 2020 · 2 comments · Fixed by #8246
Closed

Seed phrase should be forced to lowercase before test/importing #8171

mryellow opened this issue Mar 8, 2020 · 2 comments · Fixed by #8246
Labels
area-seedPhrase type-enhancement

Comments

@mryellow
Copy link

mryellow commented Mar 8, 2020

When importing a seed phrase recorded in upper-case for legibility it is rejected as invalid.

Expected behavior

Valid seed phrases should import correctly. Rejecting valid seeds as being "invalid" because of their case only functions to raise user's blood pressure and cause time wasted seeking answers.
@mryellow mryellow mentioned this issue Mar 9, 2020
Closed
@mryellow
Copy link
Author

mryellow commented Mar 9, 2020 •
edited
Loading

Whitespace other than space characters should also either be stripped or replaced with spaces, which can then be limited to 1 space between each word as part of the sanitation.

@mryellow mryellow mentioned this issue Mar 9, 2020
Open
@marktoda marktoda mentioned this issue Mar 28, 2020
Merged
marktoda added a commit to marktoda/metamask-extension that referenced this issue Mar 29, 2020
@marktoda
Make seed phrase import case insensitive
c9d716d 
The user-specified seed phrase during the first-time-flow import step
required the phrase to be entered in all lowercase. The case does not
add any extra entropy to the seed, so there's no reason to be case
sensitive. Flexibility here will improve the onboarding UX.

This commit makes the entered seed phrase case insensitive.

Fixes MetaMask#8171
whymarrh pushed a commit that referenced this issue Mar 30, 2020
@marktoda
Make seed phrase import case-insensitive (#8246)
a761b9e 
The user-specified seed phrase during the first-time-flow import step
required the phrase to be entered in all lowercase. The case does not
add any extra entropy to the seed, so there's no reason to be case
sensitive. Flexibility here will improve the onboarding UX.

This commit makes the entered seed phrase case-insensitive.

Fixes #8171
@whymarrh
Copy link
Contributor

Seed phrase should be forced to lowercase before test/importing

This is fixed with #8246, and will be in our next release. Thanks for bringing this up!

Whitespace other than space characters should also either be stripped or replaced with spaces, which can then be limited to 1 space between each word as part of the sanitation.

This should already work as expected, I can import seed phrases with newlines and tab characters and multiple spaces. Feel free to open up another issue if this isn't the case for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-seedPhrase type-enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make seed phrase import case insensitive marktoda/metamask-extension
3 participants
@mryellow @danfinlay @whymarrh