Convert modals to use JSX #7566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting lint failure here 🤔 looks like we're checking for single-quoted strings, specifically |
whymarrh
force-pushed
the
hyperscript-49
branch
from
b32322a to
b39476c
Compare
Gudahtt
reviewed
Nov 27, 2019
development/verify-locale-strings.js
Outdated
| @@ -161,7 +161,7 @@ async function verifyEnglishLocale (fix = false) { | |||
| const englishLocale = await getLocale('en') | |||
| const javascriptFiles = await findJavascriptFiles(path.resolve(__dirname, '..', 'ui')) | |||
|
|
|||
| const regex = /'(\w+)'/g | |||
| const regex = /['"](\w+)["']/g | |||
There was a problem hiding this comment.
This will catch some false positives, like "example's" would match example despite the beginning quote being different from the end quote.
Something like this would work better:
Suggested change
| const regex = /['"](\w+)["']/g | |
| const regex = /'(\w+)'|"(\w+)"/g |
However that'd create two capture groups. So the match[1] would need to be replaced with something like
match[1] || match[2]
Gudahtt
reviewed
Nov 27, 2019
| h(DepositEtherModal, {}, []), | ||
| ], | ||
| contents: [( | ||
| <DepositEtherModal key={0} /> |
There was a problem hiding this comment.
Nit: All of these single-entry arrays could be assigned the component directly instead. This contents is just passed as the children prop to the FadeModal - it's never assumed to be an array.
There was a problem hiding this comment.
Good point, I'll update these
whymarrh
force-pushed
the
hyperscript-49
branch
from
b9e0702 to
5018330
Compare
whymarrh
force-pushed
the
hyperscript-49
branch
from
5018330 to
117e3ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #6291
This PR replaces hyperscript in the modals file with JSX.