Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor everything from hyperscript to jsx #6291

Closed
danjm opened this issue Mar 12, 2019 · 2 comments · Fixed by #7680
Closed

Refactor everything from hyperscript to jsx #6291

danjm opened this issue Mar 12, 2019 · 2 comments · Fixed by #7680
Assignees

Comments

@danjm
Copy link
Contributor

danjm commented Mar 12, 2019

Lots of hyperscript still in the codebase. We should convert it all to JSX

@danjm
Copy link
Contributor Author

danjm commented Mar 12, 2019

Preferably we add a unit test before each refactor, and then refactor it.

It some cases, instead of refactoring, we can depricate the component in favour of a newer one.

@whymarrh whymarrh self-assigned this Nov 22, 2019
@whymarrh
Copy link
Contributor

whymarrh commented Nov 22, 2019

I'm going to attempt to simply convert components as a first pass.

We have the following usages:

This was referenced Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants