Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky tests Queued Confirmations... in FF for unordered events #30031

Merged
merged 14 commits into from
Jan 31, 2025
Merged

fix: flaky tests Queued Confirmations... in FF for unordered events #30031

Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0ccf12d
flakiness queued 2
seaona Jan 31, 2025
6b6e1a3
fix
seaona Jan 31, 2025
22122d0
timings
seaona Jan 31, 2025
6a21d3b
ensure txs are loaded
seaona Jan 31, 2025
85486b7
remove only
seaona Jan 31, 2025
eedfec7
fix
seaona Jan 31, 2025
9380f2b
more guards
seaona Jan 31, 2025
c4f9888
remove only
seaona Jan 31, 2025
3330504
roll back
seaona Jan 31, 2025
b5ab527
fix delay
seaona Jan 31, 2025
b1eb86f
only metrics
seaona Jan 31, 2025
f7e4318
remove console log
seaona Jan 31, 2025
c3824cd
add filters back
seaona Jan 31, 2025
ba5f69e
lint
seaona Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/e2e/tests/confirmations/alerts/queued-confirmations.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@
// create deposit transaction in dapp 1
await createDepositTransaction(driver);

await driver.delay(2000);
await driver.delay(5000);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the buffer time needs to be a bit bigger otherwise the metric events get unordered, and we get first the signature event from the dapp2 (localhost:8081) and the asserts fail

await switchToDAppTwoAndCreateSignTypedDataRequest(driver);

Expand Down Expand Up @@ -420,7 +420,7 @@
// No dialog should appear as we already gave permissions to this network
await driver.waitForSelector({
css: '[id="chainId"]',
text: '0x539',
text: '0x3e8',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my mistake, we should wait for the new chain id (changed 2 steps above)

});
}

Expand Down Expand Up @@ -478,4 +478,4 @@
await mockedTrackedQueueControllerEvent(server),
await mockedTrackedQueueControllerEvent(server),
];
}
}

Check failure on line 481 in test/e2e/tests/confirmations/alerts/queued-confirmations.spec.ts

View workflow job for this annotation

GitHub Actions / Test lint / Test lint 

Insert `⏎`
Loading