fix: flaky tests Queued Confirmations... in FF for unordered events
#30031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
seaona
changed the title
seaona
commented
Jan 31, 2025
| @@ -312,7 +312,7 @@ describe('Queued Confirmations', function () { | |||
| // create deposit transaction in dapp 1 | |||
| await createDepositTransaction(driver); | |||
|
|
|||
| await driver.delay(2000); | |||
| await driver.delay(5000); | |||
|
|
|||
There was a problem hiding this comment.
the buffer time needs to be a bit bigger otherwise the metric events get unordered, and we get first the signature event from the dapp2 (localhost:8081) and the asserts fail
seaona
commented
Jan 31, 2025
| @@ -420,7 +420,7 @@ async function switchChainToDappOne(driver: Driver) { | |||
| // No dialog should appear as we already gave permissions to this network | |||
| await driver.waitForSelector({ | |||
| css: '[id="chainId"]', | |||
| text: '0x539', | |||
| text: '0x3e8', | |||
There was a problem hiding this comment.
my mistake, we should wait for the new chain id (changed 2 steps above)
seaona
changed the title
Builds ready [ba5f69e]
Page Load Metrics (1567 ± 83 ms)
Bundle size diffs
|
DDDDDanica
approved these changes
Jan 31, 2025
|
LGTM ! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-12.13.0
seaona
changed the title
Queued Confirmations... in FF for unordered events
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An unordered metric event makes the test fail, as we see the signature one (performed after in 8081) instead of the tx one (performed first in 8080)
After looking at the logs, we can see how the 8081 event refers to the signature event that happens after the transaction
Furthermore, the wait for chainID added here was pointing to the old chainId, so now it's corrected and fixes remaining flakiness
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist