Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI crash when domain metadata is missing #10180

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Fix UI crash when domain metadata is missing #10180

merged 1 commit into from
Jan 13, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 13, 2021

The "Confirm public encryption key" page will now no longer crash when the domain metadata is missing.

Manual testing steps:

  • Somehow trigger a request for a public encryption key without supplying domain metadata (not yet sure of a good way to do this - I'll follow up)
  • Observe whether there is a UI crash in the resulting popup

@Gudahtt
Fix UI crash when domain metadata is missing
2a68856 
The "Confirm public encryption key" page will now no longer crash when
the domain metadata is missing.
@Gudahtt Gudahtt force-pushed the fix-confirm-encryption-public-key-crash-when-domain-metadata-missing branch from 1ea910d to 2a68856 Compare January 13, 2021 01:33
@Gudahtt
Copy link
Member Author

Gudahtt commented Jan 13, 2021

I was able to test this by cherry-picking this onto #10179, and clicking "GET ENCRYPTION KEY" on my version of the test dapp that is using a legacy embedded provider: https://gudahtt-test-dapp.herokuapp.com/

@Gudahtt Gudahtt marked this pull request as ready for review January 13, 2021 01:34
@Gudahtt Gudahtt requested a review from a team as a code owner January 13, 2021 01:34
@Gudahtt Gudahtt requested a review from rekmarks January 13, 2021 01:34
rekmarks
rekmarks approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You love to see it!

@metamaskbot
Copy link
Collaborator

Builds ready [2a68856]
Page Load Metrics (544 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint326947115
domContentLoaded3316025426431
load3326045446431
domInteractive3316015426431

@Gudahtt Gudahtt merged commit 9e03066 into develop Jan 13, 2021
@Gudahtt Gudahtt deleted the fix-confirm-encryption-public-key-crash-when-domain-metadata-missing branch January 13, 2021 01:53
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rekmarks rekmarks rekmarks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @metamaskbot @rekmarks