Restore support for @metamask/inpage provider@"< 8.0.0" #10179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores support for versions of the inpage provider prior to v8. This is intended to support dapps and extensions that directly instantiated their own provider rather than using the injected provider.
Gudahtt
reviewed
Jan 13, 2021
Builds ready [276aaa9]
Page Load Metrics (531 ± 42 ms)
|
rekmarks
changed the title
rekmarks
changed the title
Gudahtt
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
LGTM! I tested this with a copy of the test dapp that uses an embedded instance of v6.0.1 of our inpage provider, and is served with a CSP header of script-src: 'self' which prevents injection on Firefox.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores support for
@metamask/inpage-provider@" 8.0.0", for consumers who bring their own version of this package. The plan is to keep this support in production for about a month after communicating its removal to those consumers.