Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 3.6] Refactored a minor check in ecp check privkey #9495

Conversation

minosgalanakis
Copy link
Contributor

@minosgalanakis minosgalanakis commented Aug 21, 2024

Description

This is a backport of #166

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@minosgalanakis minosgalanakis added needs-review Every commit must be reviewed by at least two team members, single-reviewer This PR qualifies for having only one reviewer priority-low Low priority - this may not receive review soon size-xs Estimated task size: extra small (a few hours at most) labels Aug 21, 2024
@minosgalanakis minosgalanakis changed the base branch from development to mbedtls-3.6 August 21, 2024 16:04
@minosgalanakis minosgalanakis changed the title [Backport] Doc/add mbedtls ecp check privkey comment [Backport 3.6] Doc/add mbedtls ecp check privkey comment Aug 22, 2024
@minosgalanakis minosgalanakis force-pushed the doc/add_mbedtls_ecp_check_privkey_comment_bp36 branch from af992da to b7a9853 Compare August 22, 2024 12:40
@minosgalanakis minosgalanakis changed the title [Backport 3.6] Doc/add mbedtls ecp check privkey comment [Backport 3.6] Refactored a minor check in ecp check privkey Aug 22, 2024
Co-authored-by: Gilles Peskine <[email protected]>
Signed-off-by: minosgalanakis <[email protected]>
@minosgalanakis minosgalanakis force-pushed the doc/add_mbedtls_ecp_check_privkey_comment_bp36 branch from b7a9853 to 4847765 Compare January 23, 2025 15:31
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanesca yanesca added this pull request to the merge queue Jan 24, 2025
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 79d5ea2 Jan 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Every commit must be reviewed by at least two team members, priority-low Low priority - this may not receive review soon single-reviewer This PR qualifies for having only one reviewer size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants