Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mbedtls ecp check framework #166

Merged

Conversation

minosgalanakis
Copy link
Contributor

@minosgalanakis minosgalanakis commented Jan 23, 2025

Description

Added a comment based on an investigation we did at the functional behaviour of a check.

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog not required because: is a minor non functional change.
  • development PR provided
  • framework PR not required
  • 3.6 PR provided #9495
  • 2.28 PR provided #9496
  • tests not required because: is a minor non functional change.

Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but the commit message does not help me to understand why are we doing this change. I am assuming to avoid an underflow? In the future, could we please place some hints in the commit message regarding why we are doing the change at hand?

@yanesca yanesca added this pull request to the merge queue Jan 24, 2025
Merged via the queue into Mbed-TLS:development with commit fd322d2 Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants