Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move entropy init prior arguments number recognition #8810

Merged
merged 5 commits into from
Feb 14, 2024
Merged

move entropy init prior arguments number recognition #8810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2b20ff6
move entropy init prior arguments number recognition
PiotrBzdrega Feb 11, 2024
f6a9cfa
adjust indentation
PiotrBzdrega Feb 11, 2024
7238efd
changelog for bugfix
Feb 12, 2024
e0a6f7d
fill out missing dot in changelog
PiotrBzdrega Feb 13, 2024
dc6606b
newline at end of changelog file
PiotrBzdrega Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ChangeLog.d/gen-key-segfault.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Bugfix
* Avoid segmentation fault caused by releasing not initialized
entropy resource in gen_key example. Fixes #8809.
2 changes: 1 addition & 1 deletion programs/pkey/gen_key.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ int main(int argc, char *argv[])
mbedtls_mpi_init(&DQ); mbedtls_mpi_init(&QP);
#endif /* MBEDTLS_RSA_C */

PiotrBzdrega marked this conversation as resolved.
Show resolved Hide resolved
mbedtls_entropy_init(&entropy);
mbedtls_pk_init(&key);
mbedtls_ctr_drbg_init(&ctr_drbg);
memset(buf, 0, sizeof(buf));
Expand Down Expand Up @@ -336,7 +337,6 @@ int main(int argc, char *argv[])
mbedtls_printf("\n . Seeding the random number generator...");
fflush(stdout);

mbedtls_entropy_init(&entropy);
#if !defined(_WIN32) && defined(MBEDTLS_FS_IO)
if (opt.use_dev_random) {
if ((ret = mbedtls_entropy_add_source(&entropy, dev_random_entropy_poll,
Expand Down