Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move entropy init prior arguments number recognition #8810

Merged
merged 5 commits into from
Feb 14, 2024
Merged

move entropy init prior arguments number recognition #8810

merged 5 commits into from
Feb 14, 2024

Conversation

PiotrBzdrega
Copy link
Contributor

@PiotrBzdrega PiotrBzdrega commented Feb 11, 2024 •
edited by minosgalanakis
Loading

Description

Fix to issue: #8809

PR checklist

@PiotrBzdrega PiotrBzdrega marked this pull request as ready for review February 11, 2024 01:03
@PiotrBzdrega PiotrBzdrega marked this pull request as draft February 11, 2024 01:13
@PiotrBzdrega PiotrBzdrega marked this pull request as ready for review February 11, 2024 01:15
@PiotrBzdrega
adjust indentation
f6a9cfa 
Signed-off-by: PiotrBzdrega <[email protected]>
gilles-peskine-arm
gilles-peskine-arm approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm added bug needs-backports Backports are missing or are pending review and approval. priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Feb 12, 2024
gilles-peskine-arm
gilles-peskine-arm requested changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the bug fix, but please add a changelog entry.

Also, please make a similar pull request for the long-time support branch mbedtls-2.28, where the bug is also present.

programs/pkey/gen_key.c Show resolved Hide resolved
changelog for bugfix
7238efd 
Signed-off-by: Piotr Bzdręga <[email protected]>
gilles-peskine-arm
gilles-peskine-arm previously approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Feb 13, 2024
@tom-cosgrove-arm
Copy link
Contributor

@PiotrBzdrega When you've done the backport, add a link to it under the "PR checklist" at the top, please

@PiotrBzdrega PiotrBzdrega mentioned this pull request Feb 13, 2024
Merged
3 tasks
tom-cosgrove-arm
tom-cosgrove-arm previously approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm
Copy link
Contributor

(Ignore the CI failures, I accidentally started the CI jobs twice, the second job has killed the first and the failure report will go away once the second job reports back.)

@tom-cosgrove-arm
Copy link
Contributor

CI failure is

[2024-02-13T17:46:17.618Z] ******************************************************************
[2024-02-13T17:46:17.618Z] * check_files: Check: file sanity checks (permissions, encodings) 
[2024-02-13T17:46:17.618Z] * Tue Feb 13 17:46:17 UTC 2024
[2024-02-13T17:46:17.618Z] ******************************************************************
[2024-02-13T17:46:24.202Z] Missing newline at end of file:
[2024-02-13T17:46:24.202Z] ChangeLog.d/gen-key-segfault.txt
[2024-02-13T17:46:24.202Z] 
[2024-02-13T17:46:24.202Z] ^^^^check_files: Check: file sanity checks (permissions, encodings): tests/scripts/check_files.py -> 1^^^^

@tom-cosgrove-arm tom-cosgrove-arm added needs-ci Needs to pass CI tests and removed approved Design and code approved - may be waiting for CI or backports labels Feb 13, 2024
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added the needs-review Every commit must be reviewed by at least two team members, label Feb 13, 2024
@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests labels Feb 14, 2024
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Feb 14, 2024
Merged via the queue into Mbed-TLS:development with commit 0020080 Feb 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug needs-backports Backports are missing or are pending review and approval. priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PiotrBzdrega @tom-cosgrove-arm @gilles-peskine-arm