Make the explorer listnavs more compact and drop the explorer_tree #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
compact-explorer-listnav
branch
from
35826a8 to
08e7444
Compare
skateman
commented
Aug 24, 2017
| var url = '/' + $('body').data('controller') + '/accordion_select?id=' + $(e.target).attr('id'); | ||
| miqJqueryRequest(url, {beforeSend: true, complete: true}); | ||
| // No need to load anything if only a single accordion is present | ||
| if ($('#accordion > .panel').length > 1) { |
There was a problem hiding this comment.
@himdel I have a feeling that you might not like this approach here, but as we're going in the direction of components, this will be eventually moved into a controller/component around accordions.
skateman
force-pushed
the
compact-explorer-listnav
branch
from
08e7444 to
850363f
Compare
skateman
commented
Aug 24, 2017
| - if @accords | ||
| #accordion.panel-group | ||
| -# Set the first accordion as selected if there is no active_accord in the sandbox | ||
| - selected = @accords.find(-> { @accords.first }) { |accord| accord[:name].to_sym == @sb[:active_accord] } |
There was a problem hiding this comment.
Ruby keeps surprising me with things like this find syntax. I have no idea why it needs a callable, but I still ❤️ it!
skateman
force-pushed
the
compact-explorer-listnav
branch
from
850363f to
f26af33
Compare
|
Checked commit skateman@f26af33 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Tested in UI, LGTM 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a necessary next step in angularizing explorer accordions and trees:
explorer_treepartial as its being rendered only in this filemiqAccordSelectJS callbackParent issue: #1871
Possible merge conflicts with: #1984
@miq-bot add_label trees, explorers, refactoring, fine/no
@miq-bot assign @himdel