-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left-side trees on explorer screens #1871
Comments
This issue has been automatically marked as stale because it has not been updated for at least 6 months. If you can still reproduce this issue on the current release or on Thank you for all your contributions! |
@skateman is this still a valid issue? If yes, lease remove the stale label. If not can you close. |
Closing this in favor of #5178 |
After working months on the tree related code I am coming up with a concept of simplyfying the things. Let's divide our trees into two groups:
The trees on the left sidebar have a limited set of functionalities compared to the ones on the right side, e.g. no checkboxes, no multiselect, simple event handling. Also they are used exclusively for navigation on the explorer screen while the other ones are can have different use cases.
My plan is to move apart the implementation of those trees from each other for more code sharing, better testing and easier componentization. There is already a lot of work in this area, most of the left side trees are being built by the
build_accordions_and_trees
that is fetching data from thefeatures
controller method that will be probably DSL-ized in the future.Things to do:
X_TREE_NODE_CLASSES
features
andbuild_accordions_and_trees
TreeBuilder
classes related to explorer screensTreeBuilder
for building the trees on the left sideIn the future I would like to see a DSL-like thing in the controllers for declaring the structure of these trees, something very similar to the one we're using in the topology services.
Summoning for comments @martinpovolny @karelhala and @himdel!
The text was updated successfully, but these errors were encountered: