Use the common JS method for handling timeline tree onclicks #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
timelines-explorer
branch
2 times, most recently
from
b3050c2 to
218e2f1
Compare
mzazrivec
reviewed
Aug 15, 2017
| miqJqueryRequest(ManageIQ.tree.clickUrl + '?id=' + rep_id, {beforeSend: true, complete: true}); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I still see miqOnClickTimelineSelection being mentioned once in miq_tree.js.
There was a problem hiding this comment.
Totally harmless, but I'm gonna remove...
skateman
force-pushed
the
timelines-explorer
branch
from
218e2f1 to
b6f177c
Compare
|
Checked commit skateman@b6f177c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the timeline tree more similar to the trees on explorer screens.
Parent issue: #1871
@miq-bot add_label trees, refactoring, fine/no
@miq-bot assign @martinpovolny