Targeted refresh for NetworkPorts #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladas
reviewed
Jul 20, 2018
| @@ -71,7 +78,7 @@ | |||
|
|
|||
| describe "on empty database" do | |||
| it "will refresh cloud_subnet" do | |||
| cloud_subnet = FactoryGirl.build(:cloud_subnet_nuage, :ems_ref => cloud_subnet_ref1) | |||
| cloud_subnet = FactoryGirl.build(:cloud_subnet_l3_nuage, :ems_ref => cloud_subnet_ref1) | |||
There was a problem hiding this comment.
so here, :ext_management_system is missing. Has to be filled everywhere, if the table has :ems_id column
miha-plesko
force-pushed
the
targeted-network-ports
branch
from
8b84514 to
ba397e1
Compare
miha-plesko
changed the title
|
Checked commits miha-plesko/manageiq-providers-nuage@3f72ac9~...ba397e1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
This pull request is not mergeable. Please rebase and repush. |
With this commit we implement targeted refresh for NetworkPort. Signed-off-by: Miha Pleško <[email protected]>
miha-plesko
force-pushed
the
targeted-network-ports
branch
from
ba397e1 to
f951388
Compare
|
@Ladas this PR concludes targeted refresh backend. Then we only need the AE Instance in miq-content to make sure it's triggered plus the memoization followup PR as discussed on gitter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What title says ^
RFE BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1574940