Reduce memoization in targeted refresh #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're doing a lot of unneccessary caching in targeted collector. Not anymore - with this commit we simplify the code and spare memory. Rspecs are left intact and there are no errors about missing http interactions which confirms that caching was never used - because each entity is fetched and parsed only once anyway. Signed-off-by: Miha Pleško <[email protected]>
miha-plesko
force-pushed
the
reduce-memoization
branch
from
0e83717 to
87316c5
Compare
|
@miha-plesko Any idea what the memory savings are? |
|
@bronaghs haven't measured memory change but IMAO most notable thing here is that code became more readable. Memory change is not too big I think because targeted refresh works with small set of entities anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're doing a lot of unneccessary caching in targeted collector. Not anymore - with this commit we simplify the code and spare memory. Rspecs are left intact and there are no errors about missing http interactions which confirms that caching was never used - because each entity is fetched and parsed only once anyway.
RFE BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1574940