-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to fog-google 1.5.0 #64
Conversation
@miq-bot add_label refactoring, inventory |
96bf152
to
28bff79
Compare
Checked commits tumido/manageiq-providers-google@875001a~...af27946 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@miq-bot add_label blocker |
Upgrade to fog-google 1.5.0 (cherry picked from commit ba0968c) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1592504
Gaprindashvili backport details:
|
@miq-bot add_label fine/yes as recommended in BUG 1596336 |
Hi @simaishi! I'm afraid it does. In the time this PR was opened, the #54 was already in master, therefore it's not listed as dependency. The #54 has to be backported to fix the issue https://bugzilla.redhat.com/show_bug.cgi?id=1592216 and it's duplicates. So backporting both is the key probably (both are labeled fine/yes). |
Marking as |
@simaishi there will be a conflict on cherry-pick since in Fine there's no manageiq-providers-google.gemspec. This has to be moved into Gemfile. Would you like me to prepare a separate PR? |
@tumido yes, please. |
Backported to Fine via ManageIQ/manageiq#17936 |
Upgrade to
fog-google >= 1.5.0
:This PR could be used instead of #63
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1591272