[FINE] Fog google upgrade (to 1.3.3) #17914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to resolve a dependency issue and then check all the tests. |
|
Dependency conflict should be solved by ManageIQ/manageiq-gems-pending#369. However I can't test it locally, since I'm not able to build puma and rugged native extensions (openssl conflict). Huh... I'm trying to find a way how to test this. |
|
Deps are fine with current PR HEAD and when the required ManageIQ/manageiq-gems-pending#369 is used. Once that is merged Travis should pass. @miq-bot remove_label wip |
tumido
changed the title
tumido
force-pushed
the
fine-fog-google-upgrade
branch
from
bba327f to
cb69b60
Compare
tumido
force-pushed
the
fine-fog-google-upgrade
branch
from
cb69b60 to
b9aeed3
Compare
tumido
force-pushed
the
fine-fog-google-upgrade
branch
from
b9aeed3 to
48ab85c
Compare
|
Some comments on commits tumido/manageiq@336fe30~...9133e8a spec/vcr_cassettes/manageiq/providers/google/cloud_manager/refresher.yml
|
|
Checked commits tumido/manageiq@336fe30~...9133e8a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 Gemfile
**
|
|
@simaishi I've finally figured out what was wrong! This can be merged now. Should I do changes on labels for this or for the original PR (ManageIQ/manageiq-providers-google#54)? |
agrare
reviewed
Sep 10, 2018
agrare
approved these changes
Sep 10, 2018
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked version of ManageIQ/manageiq-providers-google#54 for FINE release.
Depends on:
#17258,ManageIQ/manageiq-gems-pending#369Required by: #17936