Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory::Builder functions moved to Inventory #480

Merged
merged 2 commits into from
Aug 31, 2018
+18 −71
Merged

Inventory::Builder functions moved to Inventory #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fd3866
Inventory Builder inherits from core
slemrmartin Aug 27, 2018
f0b8857
Moving Inventory Builder functionality to Inventory
slemrmartin Aug 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 0 additions & 71 deletions app/models/manageiq/providers/amazon/builder.rb
View file
Open in desktop

This file was deleted.

18 changes: 18 additions & 0 deletions app/models/manageiq/providers/amazon/inventory.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,22 @@ class ManageIQ::Providers::Amazon::Inventory < ManageIQ::Providers::Inventory
require_nested :Collector
require_nested :Parser
require_nested :Persister

# Default manager for building collector/parser/persister classes
# when failed to get class name from refresh target automatically
def self.default_manager_name
"CloudManager"
end

def self.parser_classes_for(ems, target)
case target
when ManagerRefresh::TargetCollection
[ManageIQ::Providers::Amazon::Inventory::Parser::CloudManager,
ManageIQ::Providers::Amazon::Inventory::Parser::NetworkManager,
ManageIQ::Providers::Amazon::Inventory::Parser::StorageManager::Ebs]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could do something generally with child_manager_types on ExtManagementSystem or something...

else
super
end
end

end