Inventory::Builder functions moved to Inventory #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ladas Amazon is a bit special with its builder, but it's still worth to inherit from core. Please review |
slemrmartin
changed the title
slemrmartin
force-pushed
the
inventory-builder-super
branch
from
6ea1c46 to
a0e8ae3
Compare
1 task
slemrmartin
force-pushed
the
inventory-builder-super
branch
from
a0e8ae3 to
f890493
Compare
slemrmartin
force-pushed
the
inventory-builder-super
branch
from
f890493 to
f0b8857
Compare
|
@agrare please review |
|
Checked commits slemrmartin/manageiq-providers-amazon@3fd3866~...f0b8857 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/models/manageiq/providers/amazon/inventory.rb
|
agrare
reviewed
Aug 31, 2018
| when ManagerRefresh::TargetCollection | ||
| [ManageIQ::Providers::Amazon::Inventory::Parser::CloudManager, | ||
| ManageIQ::Providers::Amazon::Inventory::Parser::NetworkManager, | ||
| ManageIQ::Providers::Amazon::Inventory::Parser::StorageManager::Ebs] |
There was a problem hiding this comment.
I wonder if we could do something generally with child_manager_types on ExtManagementSystem or something...
agrare
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common functionality extracted to
ManageIQ::Providers::Inventory