-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: threads with unread messages where wrongly flagged on mail list #480
Conversation
@sergio-jva is attempting to deploy a commit to the Zero Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis pull request modifies two files. In the Gmail API driver, unique label IDs from messages are extracted and passed into the parse function. In the mail list component, the import statement is updated to include Changes
Sequence Diagram(s)sequenceDiagram
participant GmailAPI as Gmail API
participant Driver as Google Driver
participant Parser as Parse Function
participant Logger as Console Logger
GmailAPI->>Driver: Return messages with labelIds
Driver->>Driver: Extract unique label IDs
Driver->>Parser: Call parse with message & labelIds
Parser-->>Driver: Return parsed message
Driver->>Logger: Log parsed output
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
a9a4947
to
911c53d
Compare
fix: #456 |
ee3e14d
to
f6ce043
Compare
58737a5
to
455a615
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
We are getting only the labels of the last email, so if the last email is
read we would get it as read on mail-list, even if all the new ones are unread
chages:
now we return all the labels for all the messages on a thread to verify if any
is unread
Type of Change
Please delete options that are not relevant.
Areas Affected
Please check all that apply:
Testing Done
Describe the tests you've done:
Security Considerations
Checklist
Screenshots/Recordings
Before:

After:

By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
Summary by CodeRabbit
New Features
Refactor
These improvements contribute to a significantly more efficient and reliable mail experience and lay the groundwork for exciting future enhancements.