-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
I think we can probably bump windows for 1.4, since the rc will probably catch the errors(if any exist). |
The nightly builds are from master, so issues should be caught before the rc. |
@simonjayhawkins Greenish. |
@lithomas1 i've restarted the failing job to be sure. Also reopened #135 to check current build status. if both green will merge this and then rereun #135. Should we maybe add something to the other section of 1.3.1 just in case there are issues so that users can more easily troubleshoot? I assume this is a low-risk change. if not should we wait till finished with 1.3.x before merging? |
both green. |
i guess need to revert this for the 1.3.x patch release builds |
This reverts commit ff2cf02.
…acPython#148)" This reverts commit 9fb5720.
Mirroring some changes we made in the other repo.
Not bumping windows since we are redistributing some dlls from Visual Studio 2017, and it might be risky to upgrade Visual Studio.See below