Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: v1.3.1 ImportError: DLL load failed #42733

Closed
3 tasks done
codedawi opened this issue Jul 26, 2021 · 11 comments
Closed
3 tasks done

BUG: v1.3.1 ImportError: DLL load failed #42733

codedawi opened this issue Jul 26, 2021 · 11 comments
Assignees
Labels
Blocker Blocking issue or pull request for an upcoming release Build Library building on various platforms Windows Windows OS
Milestone

Comments

@codedawi
Copy link

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • (optional) I have confirmed this bug exists on the master branch of pandas.


Note: Please read this guide detailing how to provide the necessary information for us to reproduce your bug.

Code Sample, a copy-pastable example

pip install pandas==1.3.1
import pandas as pd

Problem description

After upgrading from v1.3.0 to patch fix v1.3.1 we began receiving Import Errors on all of our scripts. We were able to resolve this by installing Visual Studio C++ Build Tools on our Windows Servers.

  • 2019 Windows Server
  • Python 3.7

Output ImportError: DLL load failed

    import pandas._libs.window.aggregations as window_aggregations
ImportError: DLL load failed: The specified module could not be found.
@codedawi codedawi added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jul 26, 2021
@jbrockmendel
Copy link
Member

@simonjayhawkins have we dropped py37 in 1.3.1?

@simonjayhawkins
Copy link
Member

no. but the vm image for windows builds was updated. MacPython/pandas-wheels#145 cc @lithomas1

@simonjayhawkins simonjayhawkins added this to the 1.3.2 milestone Jul 26, 2021
@lithomas1
Copy link
Member

On it, will send PR tmrw(it's nighttime now for me). Looks like I either copied the wrong DLLs or missed some. We should really figure out an automated way to do this.(auditwheel/delocate do this for Linux and macos) Feel free to revert the offending Or in the meantime.

Sorry for the hassle everyone.

@lithomas1 lithomas1 added Blocker Blocking issue or pull request for an upcoming release Build Library building on various platforms Windows Windows OS and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jul 27, 2021
@lithomas1
Copy link
Member

IIUC, wheels are a manual upload, so it might be possible to delete the bad 1.3.1 wheel and replace it?

@simonjayhawkins
Copy link
Member

IIUC, wheels are a manual upload, so it might be possible to delete the bad 1.3.1 wheel and replace it?

I don't have access to delete wheels. PyPI doesn't have a build number like conda? cc @jreback

@jreback
Copy link
Contributor

jreback commented Jul 27, 2021

no we cannot delete - do for 1.3.2

@lithomas1
Copy link
Member

lithomas1 commented Jul 27, 2021

This comment might be relevant.
#32857 (comment)

Looking at the aggregations pyd file in Dependencies(https://github.com/lucasg/Dependencies) and this is what I see.
image
Perhaps we need to also redistribute vcruntime140_1.dll? Not sure if we need to copy vcruntime140.dll. We are already copying msvcp140.dll and concrt140.dll.

This stuff is a PITA for me to test since you can't reproduce if you already have the VS Build Tools, which is present on CI and on my computer. Will try to get a docker environment set up to fix.

I'll also try to confirm by unzipping a good 1.3.0 windows wheel and checking the dlls.

@lithomas1 lithomas1 self-assigned this Jul 28, 2021
@lithomas1
Copy link
Member

lithomas1 commented Jul 28, 2021

I've successfully repro'ed on a docker container on azure pipelines.
See this build.
https://dev.azure.com/thomasli1234567890/pandas/_build/results?buildId=15&view=logs&j=ebcc7698-9622-5b0b-70f1-97d524978b97
Testing my solution now.

@simonjayhawkins
Copy link
Member

@lithomas1 MacPython/pandas-wheels#148 has been merged. can we close this issue?

@lithomas1
Copy link
Member

Sure I guess. I think that we probably want to open a new issue about automatically catching the missing DLL issue, as this is the second time its happened(and we don't want it to happen every time we upgrade Visual Studio).

@simonjayhawkins
Copy link
Member

open a new issue about automatically catching the missing DLL issue

issue should be in https://github.com/MacPython/pandas-wheels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Blocking issue or pull request for an upcoming release Build Library building on various platforms Windows Windows OS
Projects
None yet
Development

No branches or pull requests

5 participants