-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elasticsearch support to tugboat. #413
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f6e7c6d
Add elasticsearch support to tugboat.
KeyboardCowboy 1792ef4
Fix white space on config.
KeyboardCowboy 044184f
Run Tugboat test against more robust tugboat config test file.
KeyboardCowboy 4e9cca8
Stop polluting .gitignore with ide settings.
KeyboardCowboy 3054a66
Revert Tugboat testing and add redis and elastic search.
KeyboardCowboy 591e6dd
Lock in redis and elasticsearch versions so tests know what version t…
KeyboardCowboy 7fe09c2
Replace cmp with diff so we can see errors in logs
deviantintegral e02be92
Add redis dependency.
KeyboardCowboy dcd279a
Merge branch '387--tugboat-elasticsearch' of github.com:Lullabot/drai…
KeyboardCowboy c39dda9
Update .github/workflows/TestTugboat.yml
justafish cf586a3
Merge branch 'main' into 387--tugboat-elasticsearch
justafish 5f4f11f
Update test
justafish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,12 +28,17 @@ jobs: | |
git-email: [email protected] | ||
ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }} | ||
|
||
# Lock in versions so tests know what to expect. | ||
# Redis tag v1.2.0 == 6-bullseye | ||
# Elasticsearch tag v0.3.2 == 7.17.14 | ||
- name: Setup Project | ||
run: | | ||
ddev config --auto | ||
ddev config --php-version "8.1" | ||
ddev config --nodejs-version "18" | ||
ddev config --database=mariadb:10.4 | ||
ddev get ddev/ddev-redis --version v1.2.0 | ||
ddev get ddev/ddev-elasticsearch --version v0.3.2 | ||
ddev start | ||
ddev composer config extra.drupal-scaffold.gitignore true | ||
ddev composer config --json extra.drupal-scaffold.allowed-packages \[\"lullabot/drainpipe\"] | ||
|
@@ -49,13 +54,13 @@ jobs: | |
# preview - they should be the same. | ||
- name: Test Generated Files | ||
run: | | ||
cmp -b drainpipe/.tugboat/config.yml .tugboat/config.yml | ||
diff -up drainpipe/.tugboat/config.yml .tugboat/config.yml | ||
sed -i '/#drainpipe-start/,/#drainpipe-end/d' drainpipe/.tugboat/steps/1-init.sh | ||
sed -i '/#drainpipe-start/,/#drainpipe-end/d' drainpipe/.tugboat/steps/2-update.sh | ||
sed -i '/#drainpipe-start/,/#drainpipe-end/d' drainpipe/.tugboat/steps/3-build.sh | ||
cmp -b drainpipe/.tugboat/steps/1-init.sh .tugboat/steps/1-init.sh | ||
cmp -b drainpipe/.tugboat/steps/2-update.sh .tugboat/steps/2-update.sh | ||
cmp -b drainpipe/.tugboat/steps/3-build.sh .tugboat/steps/3-build.sh | ||
diff -up drainpipe/.tugboat/steps/1-init.sh .tugboat/steps/1-init.sh | ||
diff -up drainpipe/.tugboat/steps/2-update.sh .tugboat/steps/2-update.sh | ||
diff -up drainpipe/.tugboat/steps/3-build.sh .tugboat/steps/3-build.sh | ||
|
||
- name: Add a build:tugboat step | ||
run: | | ||
|
@@ -114,4 +119,3 @@ jobs: | |
run: | | ||
cat .tugboat/steps/1-init.sh | ||
grep -q NODE_MAJOR=16 .tugboat/steps/1-init.sh | ||
justafish marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to find a way to test my changes by generating a more robust config file and testing it against a more complete example. The test runner doesn't seem to be able to locate this file, though, so I'm not sure if I'm doing something wrong or if there's a better way to test my work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KeyboardCowboy the way we're currently testing it is by having the Tugboat file generated match the one we're using to create a Tugboat environment - bit of a hack, but unfortunately we can't generate a tugboat configuration on the fly. If you add elastic search to
.tugboat/config.yml
then that should be fine. Is there anything we can add to verify that elasticsearch has started correctly and is usable by Drupal?