-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elasticsearch support to tugboat. #413
Conversation
@@ -49,7 +51,7 @@ jobs: | |||
# preview - they should be the same. | |||
- name: Test Generated Files | |||
run: | | |||
cmp -b drainpipe/.tugboat/config.yml .tugboat/config.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to find a way to test my changes by generating a more robust config file and testing it against a more complete example. The test runner doesn't seem to be able to locate this file, though, so I'm not sure if I'm doing something wrong or if there's a better way to test my work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KeyboardCowboy the way we're currently testing it is by having the Tugboat file generated match the one we're using to create a Tugboat environment - bit of a hack, but unfortunately we can't generate a tugboat configuration on the fly. If you add elastic search to .tugboat/config.yml
then that should be fine. Is there anything we can add to verify that elasticsearch has started correctly and is usable by Drupal?
@@ -49,7 +51,7 @@ jobs: | |||
# preview - they should be the same. | |||
- name: Test Generated Files | |||
run: | | |||
cmp -b drainpipe/.tugboat/config.yml .tugboat/config.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KeyboardCowboy the way we're currently testing it is by having the Tugboat file generated match the one we're using to create a Tugboat environment - bit of a hack, but unfortunately we can't generate a tugboat configuration on the fly. If you add elastic search to .tugboat/config.yml
then that should be fine. Is there anything we can add to verify that elasticsearch has started correctly and is usable by Drupal?
I adjusted the |
@KeyboardCowboy that's a great question. From what I can tell, since diff also sets an error exit code if it fails we can use that, and get the advantage of not having to replicate this locally. I pushed up a commit to this PR changing that, and you can see the test error in the CI logs. I'll let you fix it! |
…npipe into 387--tugboat-elasticsearch
Thanks, Andrew. It looks like it's working now. Do I need to do something about the sass/JS compilation error? I'm not sure that has anything to do with my changes. |
If you have a look at the error log you can see it failed at downloading the DDEV images, so you can just re-run that test https://github.com/Lullabot/drainpipe/actions/runs/7964643194/job/21742704685?pr=413 |
Resolves #387