Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix align overflow #251

Closed
wants to merge 1 commit into from
Closed

Conversation

slavonnet
Copy link

@slavonnet slavonnet commented Oct 30, 2021

Need review. I think must be more condotons

@slavonnet slavonnet marked this pull request as draft October 30, 2021 07:27
@slavonnet slavonnet changed the base branch from master to new_engine October 30, 2021 07:28
@slavonnet slavonnet changed the title fixAlign Fix align overflow Oct 30, 2021
@slavonnet slavonnet marked this pull request as ready for review October 30, 2021 07:30
@slavonnet
Copy link
Author

@slavonnet
Copy link
Author

Before fix tool say : fss align 10h greater than vilume. But fss align can't be more 7 and on debug i se Zero or x40 in attrs. Rewrite to remove any overflow

@NikolajSchlej
Copy link
Collaborator

We will not accept any pull-requests without first getting a good understanding of the reason for modification, an agreement of the need for modification, and the technical details of it.

Please provide more context to your fixes in a separate issue:

  • what is the nature of the issue
  • is there an image that has this issue reproducible
  • if so, how we can reproduce it
  • what is the difference between expected and observed behaviors
  • what is the way to test that the modification actually fixes the issue and doesn't introduce any new ones

I will leave this PR without action until the questions above are answered and me and @vit9696 are in agreement on the solution.

@NikolajSchlej
Copy link
Collaborator

"Before fix tool say : fss align 10h greater than volume"
This is a legitimate error message coming from the following paragraph in the UEFI PE specification:
volume_alignment

The error message you see indicates that there's a file in that volume that required 16 byte alignment, but the volume itself was aligned by a lower boundary, most likely 8.

However, there's still an issue in UEFITool because the EFI_FVB2_WEAK_ALIGNMENT handling is not performed yet, and such volumes will be reported as improperly aligned despite not being so. This will be fixed, but the PR here needs to be closed unmerged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment